fix(relay): external addr not expiring when relayed listen addr expire #5577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormshield-frb
force-pushed
the
fix/relay-not-expiring-external-address
branch
from
96bff78
to
6aff4f8
Compare
stormshield-frb
changed the title
stormshield-frb
changed the title
stormshield-frb
force-pushed
the
fix/relay-not-expiring-external-address
branch
3 times, most recently
from
5bceae6
to
d24cf31
Compare
stormshield-frb
force-pushed
the
fix/relay-not-expiring-external-address
branch
2 times, most recently
from
eeefabb
to
cfb5cd1
Compare
…sten through relay
stormshield-frb
force-pushed
the
fix/relay-not-expiring-external-address
branch
from
cfb5cd1
to
2918c54
Compare
|
Thanks! Just as an fyi, there is no need to force push as the commits will all be squashed when it is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We encountered a bug when our app is connected and listening through a relay and that it decided to stop listening through the relay but still let the connection with the relay open (some other streams are opened with this peer), then the previously confirmed
ExternalAddressdoes not expire.The PR solves this problem and simplify a little bit the way to emit
ExternalAddrConfirmedandExternalAddrExpiredby only watchingNewListenAddrandExpiredListenAddrevents if they are notifying about a relayed listen address.Also, when renewing reservation,
NewListenAddrshould not be emitted again if the samelisten_addris given, but it should emit aListenAddrExpiredevent if a previously reserved one was not reserved again.Notes & open questions
I have also included a correlated change by removing the
/p2p/<local_peer_id>of the relayed listen addresses and external addresses (corresponding to a listen addresses). Indeed, every other transport does not include it so I think it is better that therelaytransport acts the same. If necessary, I can do a separated PR.Change checklist